Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18615#discussion_r127160628
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2087,10 +2087,13 @@ def _wrapped(self):
             """
             Wrap this udf with a function and attach docstring from func
             """
    -        @functools.wraps(self.func)
    +        assignments = tuple(a for a in functools.WRAPPER_ASSIGNMENTS if a 
!= "__name__")
    --- End diff --
    
    I'd put a comment here saying what this is for just so that when we see 
this next year we don't forget why we stripped out name from the things we 
asked functools to assign.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to