Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18617#discussion_r127299428
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -192,16 +193,29 @@ private[spark] class Client(
* Cleanup application staging directory.
*/
private def cleanupStagingDir(appId: ApplicationId): Unit = {
- val stagingDirPath = new Path(appStagingBaseDir,
getAppStagingDir(appId))
- try {
- val preserveFiles = sparkConf.get(PRESERVE_STAGING_FILES)
- val fs = stagingDirPath.getFileSystem(hadoopConf)
- if (!preserveFiles && fs.delete(stagingDirPath, true)) {
- logInfo(s"Deleted staging directory $stagingDirPath")
+ def cleanupStagingDirInternal(): Unit = {
+ val stagingDirPath = new Path(appStagingBaseDir,
getAppStagingDir(appId))
+ try {
+ val preserveFiles = sparkConf.get(PRESERVE_STAGING_FILES)
--- End diff --
You could do this check before even trying anything else in this method
(just return early).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
