Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18571#discussion_r127396793
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/OrderingSuite.scala
---
@@ -137,4 +137,26 @@ class OrderingSuite extends SparkFunSuite with
ExpressionEvalHelper {
// verify that we can support up to 5000 ordering comparisons, which
should be sufficient
GenerateOrdering.generate(Array.fill(5000)(sortOrder))
}
+
+ test("SPARK-21344: BinaryType comparison does signed byte array
comparison") {
+ val data = Seq(
+ (Array[Byte](1), Array[Byte](-1)),
+ (Array[Byte](1, 1, 1, 1, 1), Array[Byte](1, 1, 1, 1, -1)),
+ (Array[Byte](1, 1, 1, 1, 1, 1, 1, 1, 1), Array[Byte](1, 1, 1, 1, 1,
1, 1, 1, -1))
+ )
+ data.foreach { case (b1, b2) =>
+ val rowOrdering = InterpretedOrdering.forSchema(Seq(BinaryType,
BinaryType))
+ val genOrdering = GenerateOrdering.generate(
+ BoundReference(0, BinaryType, nullable = true).asc ::
+ BoundReference(1, BinaryType, nullable = true).asc :: Nil)
+ val rowType = StructType(
+ StructField("b1", BinaryType, nullable = true) ::
+ StructField("b2", BinaryType, nullable = true) :: Nil)
--- End diff --
You specify two binary fields as row schema. But actually your input just
has one binary field (i.e., Row(b1)).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
