Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/18629#discussion_r127519438
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
@@ -172,7 +172,9 @@ private[state] class HDFSBackedStateStoreProvider
extends StateStoreProvider wit
}
}
- override def numKeys(): Long = mapToUpdate.size()
+ override def metrics: StateStoreMetrics = {
+ StateStoreMetrics(mapToUpdate.size(),
SizeEstimator.estimate(mapToUpdate), Map.empty)
--- End diff --
Should we add a flag for this? `SizeEstimator.estimate` will be very slow
when there are a lot of states, because it scans all objects using reflection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
