GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/18637
[SPARK-15526][ML][FOLLOWUP] Make JPMML provided scope to avoid including
unshaded JARs, and repromote to compile in MLlib
## What changes were proposed in this pull request?
Following the comment at
https://issues.apache.org/jira/browse/SPARK-15526?focusedCommentId=16086106&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16086106
-- this change actually needed a little more work to be complete.
This also marks JPMML as `provided` to make sure its JARs aren't included
in the `jars` output, but then scopes to `compile` in `mllib`. This is how
Guava is handled.
## How was this patch tested?
Checked result in `assembly/target/scala-2.11/jars` to verify there are no
JPMML jars. Maven and SBT builds still work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-15526.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18637
----
commit 4b20f822c9d76a2168fc4fe8094d8f22eecd5d93
Author: Sean Owen <[email protected]>
Date: 2017-07-14T09:10:13Z
Make JPMML provided scope to avoid including unshaded JARs, and repromote
to compile in MLlib; similar to Guava approach
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
