Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18633#discussion_r127562035
--- Diff:
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala
---
@@ -42,7 +42,7 @@ import org.apache.spark.internal.Logging
private[spark] class HadoopDelegationTokenManager(
sparkConf: SparkConf,
hadoopConf: Configuration,
- fileSystems: Set[FileSystem])
+ fileSystems: () => Set[FileSystem])
--- End diff --
I think this closure needs to take a `Configuration` as paramater.
If you look at the old code, when renewing tokens, the file system list
uses `AMCredentialRenewer.freshHadoopConf` as the configuration, not the
`ApplicationMaster` configuration as your code is doing. That sounds more
correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
