Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2570#discussion_r18242621
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
---
    @@ -32,6 +32,54 @@ case class Nested3(f3: Int)
      * valid, but Hive currently cannot execute it.
      */
     class SQLQuerySuite extends QueryTest {
    +  test("CTAS with serde") {
    +    sql("CREATE TABLE ctas1 AS SELECT key k, value FROM src ORDER BY k, 
value").collect
    +    sql(
    +      """CREATE TABLE ctas2
    +        | ROW FORMAT SERDE 
"org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe"
    +        | STORED AS RCFile AS
    +        |   SELECT key, value
    +        |   FROM src
    +        |   ORDER BY key, value""".stripMargin).collect
    --- End diff --
    
    I am not sure we should just check the contents of created tables to test 
whether we can correctly set some table properties. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to