Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18612#discussion_r127584690
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -162,7 +162,7 @@ private[ml] trait HasThreshold extends Params {
* Param for threshold in binary classification prediction, in range [0,
1].
* @group param
*/
- final val threshold: DoubleParam = new DoubleParam(this, "threshold",
"threshold in binary classification prediction, in range [0, 1]",
ParamValidators.inRange(0, 1))
+ val threshold: DoubleParam = new DoubleParam(this, "threshold",
"threshold in binary classification prediction, in range [0, 1]",
ParamValidators.inRange(0, 1))
setDefault(threshold, 0.5)
--- End diff --
Maybe the error can be eliminated after removing this line, and actually we
should set default value in the concrete class if it's inherited.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
