Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127625968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,31 @@ case class CaseWhenCodegen(
val cases = branches.map { case (condExpr, valueExpr) =>
val cond = condExpr.genCode(ctx)
val res = valueExpr.genCode(ctx)
+ val (condFunc, condIsNull, condValue) = if ((cond.code.length >=
512) &&
+ // Split these expressions only if they are created from a row
object
+ (ctx.INPUT_ROW != null && ctx.currentVars == null)) {
+ val (funcName, globalIsNull, globalValue) =
+ CondExpression.createAndAddFunction(ctx, cond,
condExpr.dataType, "caseWhenCondExpr")
+ (s"$funcName(${ctx.INPUT_ROW});", globalIsNull, globalValue)
+ } else {
+ (cond.code, cond.isNull, cond.value)
+ }
+ val (resFunc, resIsNull, resValue) = if ((res.code.length >= 512) &&
+ // Split these expressions only if they are created from a row
object
+ (ctx.INPUT_ROW != null && ctx.currentVars == null)) {
--- End diff --
We can move this condition above and reuse it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
