Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18620 So in the first case there is a slight win with `array.sortBy` (but not that much if I recall, they are more or less on par?) and in the second case poll is a lot faster? Given the default block size in ALS, the 1st scenario is by far the most likely, right? But for very small item sizes it could be different (but in that case, frankly performance won't really be any issue). I mean, it's a private util so adding `poll` is not a big deal. It just feels a little unnecessary. On Mon, 17 Jul 2017 at 13:37 Meng, Peng <notificati...@github.com> wrote: > I have tested much about poll and toArray.sorted. > If the queue is much ordered (suppose offer 2000 times for queue size 20). > Use pq.toArray.sorted is faster. > If the queue is much disordered (suppose offer 100 times for queue size > 20), Use pq.poll is much faster. > > â > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/18620#issuecomment-315731414>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AA_SB17ZqiWE1BMmuX8IdHTce0NYJSlkks5sO0djgaJpZM4OWot0> > . >
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org