Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18616#discussion_r127774484
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -438,6 +441,24 @@ private[spark] class ApplicationMaster(
registerAM(sparkConf, rpcEnv, driverRef,
sparkConf.getOption("spark.driver.appUIAddress"),
securityMgr)
+ // If the credentials file config is present, we must periodically
renew tokens. So create
--- End diff --
Hmm, I know I already said "LGTM", but I think these two paths could be
consolidated into one.
Basically, move this code to the `run()` method before either driver or
executor launcher is started; then there's a single place where the token
renewer is started, and then both client and cluster mode start it the same way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
