Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18658#discussion_r127819158
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1037,24 +1037,22 @@ object CodeGenerator extends Logging {
))
evaluator.setExtendedClass(classOf[GeneratedClass])
- lazy val formatted = CodeFormatter.format(code)
-
logDebug({
// Only add extra debugging info to byte code when we are going to
print the source code.
evaluator.setDebuggingInformation(true, true, false)
- s"\n$formatted"
+ s"\n${CodeFormatter.format(code)}"
--- End diff --
I'd suggest dropping the string concatenation with `\n` here -- it requires
an additional copy of the code to be held in-memory and for errors where the
code is too long, this causes unnecessary additional pressure on the heap
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
