Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18652#discussion_r127903005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1912,6 +1913,26 @@ class Analyzer(
nondeterToAttr.get(e).map(_.toAttribute).getOrElse(e)
}.copy(child = newChild)
+ case j: Join if j.condition.isDefined &&
!j.condition.get.deterministic =>
+ j match {
+ // We can push down non-deterministic joining keys.
+ // We can't push down non-deterministic conditions.
+ case ExtractEquiJoinKeys(_, leftKeys, rightKeys, conditions, _,
_)
--- End diff --
I do not think we can have an easy solution to ensure it always works as
you expected. `EnsureRequirements` is just one of rules that could break it.
The other preceding join conditions before equi join condition also could
impact it. It could be skipped if the preceding join conditions is false, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
