Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18632#discussion_r127908258
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -51,6 +51,7 @@ public UnsafeRowWriter(BufferHolder holder, int
numFields) {
this.nullBitsSize = UnsafeRow.calculateBitSetWidthInBytes(numFields);
this.fixedSize = nullBitsSize + 8 * numFields;
this.startingOffset = holder.cursor;
+ holder.reset();
--- End diff --
@cloud-fan @viirya For your worries, maybe we can move the `holder.reset()`
to `BufferHolder`'s constructor. Then the holder will be reset only once, and
also it'ok to continue writing from a buffer's current cursor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
