Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18641#discussion_r127965239
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
---
@@ -273,12 +274,26 @@ case class CaseWhenCodegen(
val cases = branches.map { case (condExpr, valueExpr) =>
val cond = condExpr.genCode(ctx)
val res = valueExpr.genCode(ctx)
+ val (condFunc, condIsNull, condValue, resFunc, resIsNull, resValue )
=
+ if ((cond.code.length + res.code.length) > 1024 &&
--- End diff --
Actually my previous comment meant the sum of generated codes of all
branches.
With latest commit, it is possible that the code size of each branch is in
the range, but the sum of all branches still breaks 64KB limit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
