Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r128202464
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1458,4 +1475,167 @@ class GeneralizedLinearRegressionTrainingSummary
private[regression] (
"No p-value available for this GeneralizedLinearRegressionModel")
}
}
+
+ /**
+ * Coefficient matrix with feature name, coefficient, standard error,
+ * tValue and pValue.
+ */
+ @Since("2.3.0")
+ lazy val coefficientMatrix: Array[(String, Double, Double, Double,
Double)] = {
--- End diff --
This is not a matrix, so it's not appropriate to name it as
```coefficientMatrix```. Since it's only used for generating summary string
output, what about keep it private or inline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
