GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/18681
[MINOR][ML] Reorg RFormula params.
## What changes were proposed in this pull request?
There are mainly two reasons for this reorg:
* Some params are placed in ```RFormulaBase```, while others are placed in
```RFormula```, this is disordered.
* ```RFormulaModel``` should have params ```handleInvalid```, ```formula```
and ```forceIndexLabel```, that users can get invalid values handling policy,
formula or whether to force index label if they only have a
```RFormulaModel```. So we need move these params to ```RFormulaBase``` which
is also inherited by ```RFormulaModel```.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark rformula-reorg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18681
----
commit 673d2dfdc32c4ec7e298e9c448ddafe6d3d7ea7a
Author: Yanbo Liang <[email protected]>
Date: 2017-07-19T11:26:08Z
Reorg RFormula params.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
