Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18543#discussion_r128239090
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -118,26 +124,28 @@ public int compare(RecordPointerAndKeyPrefix r1,
RecordPointerAndKeyPrefix r2) {
public UnsafeInMemorySorter(
final MemoryConsumer consumer,
final TaskMemoryManager memoryManager,
- final RecordComparator recordComparator,
+ final RecordComparator.Factory recordComparatorFactory,
--- End diff --
Why do we need to change `UnsafeInMemorySorter`. The `TaskContext` refers
`UnsafeExternalSorter`, so we only need the comparator factory in
`UnsafeExternalSorter`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
