Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18651#discussion_r128249084
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
 ---
    @@ -294,7 +296,8 @@ private[yarn] class YarnAllocator(
       def updateResourceRequests(): Unit = {
         val pendingAllocate = getPendingAllocate
         val numPendingAllocate = pendingAllocate.size
    -    val missing = targetNumExecutors - numPendingAllocate - 
numExecutorsRunning
    +    val missing = targetNumExecutors - numPendingAllocate -
    +      numExecutorsStarting.get - numExecutorsRunning.get
     
    --- End diff --
    
    can you also add in a debug message here, something like below.  I found 
this very useful when debugging this issue and think it would be useful for 
debugging other allocating issues in the future.
    
    logDebug(s"Updating resource requests, target: $targetNumExecutors, 
pending: " +
     +      s"$numPendingAllocate, running: $numExecutorsRunning, 
executorsStarting $numExecutorsPendingStart")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to