Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18492#discussion_r128452352
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -572,20 +572,35 @@ private[spark] class ExecutorAllocationManager(
       }
     
       /**
    +   * Callback invoked when an extra executor is needed (See SPARK-19326)
    +   */
    +  private def onExtraExecutorNeeded(): Unit = synchronized {
    +    val maxNeeded = math.max(math.min(maxNumExecutorsNeeded + 1, 
maxNumExecutors), minNumExecutors)
    --- End diff --
    
    Perhaps what we need is just to ensure there are more than two active 
executors left, so we may meet the locality requirement and launch the 
speculative jobs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to