Github user debasish83 commented on the pull request:

    https://github.com/apache/spark/pull/840#issuecomment-57411813
  
    @codedeft I am trying to test OWLQN and compare with a C++ baseline on our 
data but it seems it runs only one iteration...I am setting up 10 iterations 
and convergenceTol as 1e-4...caller code is simple:
    
    class LogisticRegressionWithBFGS private (                                  
                                                                                
                     
      private var numIterations: Int,                                           
                                                                                
                     
      private var alpha: Double,                                                
                                                                                
                     
      private var regParam: Double)                                             
                                                                                
                     
      extends GeneralizedLinearAlgorithm[LogisticRegressionModel] with 
Serializable {    
      private val gradient = new LogisticGradient()                             
                                                                                
                                                                                
                                                                                
                                  
      override val optimizer = new 
OWLQN(gradient).setAlpha(alpha).setRegParam(regParam)                           
                                                                  
      override protected val validators = 
List(DataValidators.binaryLabelValidator)                                       
                                                           
      override protected def createModel(weights: Vector, intercept: Double) = 
{                                                                               
                      
        new LogisticRegressionModel(weights, intercept)                         
                                                                                
                     
      }                                                                         
                                                                                
                     
    }
    
    Are there any issues with the way Breeze OWLQN is called ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to