Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/18487#discussion_r128572125
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -375,6 +390,7 @@ final class ShuffleBlockFetcherIterator(
result match {
case r @ SuccessFetchResult(blockId, address, size, buf,
isNetworkReqDone) =>
if (address != blockManager.blockManagerId) {
+ numBlocksInFlightPerAddress(address) =
numBlocksInFlightPerAddress(address) - 1
--- End diff --
That is a good point. Infact, we could also move the other bookkeeping
stuff right after the fetch result is enqueued.
I would also want to look at the initialization of the
BlockFetchingListener to see the effects of this as it would increase the size
of the closure. Can we have a separate JIRA filed for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
