Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18694#discussion_r128679491
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
---
@@ -649,6 +660,11 @@ private[joins] class SortMergeJoinScanner(
// Initialization (note: do _not_ want to advance streamed here).
advancedBufferedToRowWithNullFreeJoinKey()
+ def destruct(): Unit = {
+ while (streamedIter.advanceNext()) {}
+ while (bufferedIter.advanceNext()) {}
--- End diff --
It does introduce extra overhead. The other way is to introduce a new
interface for RowIterator to destruct itself. But memory leak is worse than
extra overhead, because it causes more spill.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
