Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2595#discussion_r18260051
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -437,6 +433,7 @@ object DecisionTree extends Serializable with Logging {
* @param treeToNodeToIndexInfo Mapping: treeIndex --> nodeIndex -->
nodeIndexInfo,
* where nodeIndexInfo stores the index in
the group and the
* feature subsets (if using feature
subsets).
+ * @param nodeToFeatures Mapping: nodeIndexInGroup -> feature subsets
--- End diff --
This basically duplicates the information held in treeToNodeToIndexInfo.
Could you please only use 1 of these maps? That will help keep the code
simpler. The original map treeToNodeToIndexInfo holds a bit more info, so
keeping that one and not introducing a new map seems easiest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
