Github user pjfanning commented on a diff in the pull request:
https://github.com/apache/spark/pull/18658#discussion_r128719338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
---
@@ -28,14 +28,22 @@ import java.util.regex.Matcher
object CodeFormatter {
val commentHolder = """\/\*(.+?)\*\/""".r
- def format(code: CodeAndComment): String = {
+ def format(code: CodeAndComment): String = format(code, -1)
+
+ def format(code: CodeAndComment, maxLines: Int): String = {
--- End diff --
@srowen I can make that change. Is there any need to scaladoc the maxLines
param? Or is the function definition easy enough to follow?
```
def format(code: CodeAndComment, maxLines: Int = -1): String
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
