Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/18281#discussion_r128828428
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -271,7 +273,7 @@ object OneVsRestModel extends
MLReadable[OneVsRestModel] {
@Since("1.4.0")
final class OneVsRest @Since("1.4.0") (
@Since("1.4.0") override val uid: String)
- extends Estimator[OneVsRestModel] with OneVsRestParams with MLWritable {
+ extends Estimator[OneVsRestModel] with OneVsRestParams with
HasParallelism with MLWritable {
--- End diff --
@WeichenXu123 earlier in the discussion for this PR we had been
coordinating with similar changes for parallel cross validator and train
validation split at #16774 .
If `trait OneVsRestParams extends PredictorParams with HasParallelism` was
done instead, then it would just give the parallelism param to the
`OneVsRestModel` which isn't really useful since it's already been trained.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
