Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18695#discussion_r128830285
  
    --- Diff: python/pyspark/broadcast.py ---
    @@ -139,6 +139,29 @@ def __reduce__(self):
             return _from_id, (self._jbroadcast.id(),)
     
     
    +class BroadcastPickleRegistry(object):
    +    """ Thread-safe registry for broadcast variables that have been pickled
    +    """
    +
    +    def __init__(self, lock):
    +        self._registry = set()
    +        self._lock = lock
    +
    +    @property
    --- End diff --
    
    sure @HyukjinKwon, it's not really necessary.  It's just there to basically 
say that the lock should not be changed once this class is instantiated, so to 
keep it "private" but allowed to be acquired.  Maybe it's overkill here because 
this is not a widely used class with a very specific use.  I could remove it if 
that makes things easier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to