Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18645#discussion_r128892216
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala 
---
    @@ -353,7 +353,7 @@ class DatasetSuite extends QueryTest with 
SharedSQLContext {
       test("foreachPartition") {
         val ds = Seq(("a", 1), ("b", 2), ("c", 3)).toDS()
         val acc = sparkContext.longAccumulator
    -    ds.foreachPartition(_.foreach(v => acc.add(v._2)))
    +    ds.foreachPartition((it: Iterator[(String, Int)]) => it.foreach(v => 
acc.add(v._2)))
    --- End diff --
    
    Actually, no not the same issue as 
https://issues.apache.org/jira/browse/SPARK-14643 but similar. Let me ask the 
question there about how much source compatibility matters across Scala 
versions, _for Java_.
    
    I'm not in any event proposing to enable a 2.12 build anytime soon, just 
see if we can get it closer without any implications for 2.11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to