Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18714#discussion_r128912116
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -162,5 +198,8 @@ class HadoopMapReduceCommitProtocol(jobId: String,
path: String)
val tmp = new Path(src)
tmp.getFileSystem(taskContext.getConfiguration).delete(tmp, false)
}
+ if (runtimeOverwritePartition) {
--- End diff --
If we just read this function without the context of this PR, I might ask
why we drop the staging directory only when `runtimeOverwritePartition ` is
true?
Any reason we want to keep it unchanged when `runtimeOverwritePartition `
is false?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
