Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18540#discussion_r129005233
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -267,16 +267,17 @@ class ExpressionParserSuite extends PlanTest {
// Range/Row
val frameTypes = Seq(("rows", RowFrame), ("range", RangeFrame))
val boundaries = Seq(
- ("10 preceding", ValuePreceding(10), CurrentRow),
- ("3 + 1 following", ValueFollowing(4), CurrentRow), // Will fail
during analysis
- ("unbounded preceding", UnboundedPreceding, CurrentRow),
- ("unbounded following", UnboundedFollowing, CurrentRow), // Will
fail during analysis
- ("between unbounded preceding and current row", UnboundedPreceding,
CurrentRow),
+ ("10 preceding", -Literal(10), CurrentRow),
+ ("2147483648 preceding", -Literal(2147483648L), CurrentRow),
+ ("3 + 1 following", Add(Literal(3), Literal(1)), CurrentRow), //
Will fail during analysis
--- End diff --
Do you think that will improve the UX?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
