GitHub user aokolnychyi opened a pull request:

    https://github.com/apache/spark/pull/18740

    [SPARK-21538][SQL] Attribute resolution inconsistency in the Dataset API

    ## What changes were proposed in this pull request?
    
    This PR contains a tiny update that removes an attribute resolution 
inconsistency in the Dataset API. The following example is taken from the 
ticket description:
    
    ```
    spark.range(1).withColumnRenamed("id", "x").sort(col("id"))  // works
    spark.range(1).withColumnRenamed("id", "x").sort($"id")  // works
    spark.range(1).withColumnRenamed("id", "x").sort('id) // works
    spark.range(1).withColumnRenamed("id", "x").sort("id") // fails with:
    org.apache.spark.sql.AnalysisException: Cannot resolve column name "id" 
among (x);
    ```
    The above `AnalysisException` happens because the last case calls 
`Dataset.apply()` to convert strings into columns, which triggers attribute 
resolution. To make the API consistent between overloaded methods, this PR 
delays the resolution and constructs columns directly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aokolnychyi/spark spark-21538

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18740
    
----
commit b0fbd5ee98de0ed725d96e63943da934150f6c3e
Author: aokolnychyi <[email protected]>
Date:   2017-07-26T19:56:44Z

    [SPARK-21538][SQL] Fix attribute resolution inconsistency in the Dataset API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to