Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18761#discussion_r130215991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -241,6 +241,7 @@ trait RuntimeReplaceable extends UnaryExpression with
Unevaluable {
override def nullable: Boolean = child.nullable
override def foldable: Boolean = child.foldable
override def dataType: DataType = child.dataType
+ override lazy val canonicalized: Expression = child.canonicalized
--- End diff --
First, my only concern is `CleanupAliases` might be called in the other
Analyzer rules. These unneeded aliases could break the assumptions made by the
caller of `CleanupAliases`.
Second, you should post what I said above in the PR description. So far,
the description is not clear to the reviewers.
Third, I am ok about the fix, but we should write the comments to explain
why we did it here. We need to add two comments. One is in `CleanupAliases `;
another is above this line to explain why we add `canonicalized`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
