Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2618#discussion_r18296675
  
    --- Diff: 
external/twitter/src/main/scala/org/apache/spark/streaming/twitter/TwitterUtils.scala
 ---
    @@ -32,6 +32,26 @@ object TwitterUtils {
        *        authorization; this uses the system properties 
twitter4j.oauth.consumerKey,
        *        twitter4j.oauth.consumerSecret, twitter4j.oauth.accessToken and
        *        twitter4j.oauth.accessTokenSecret
    +   * @param query Twitter4j filter query, or None to return a stream of 
random sample
    +   *              of all public statuses
    +   * @param storageLevel Storage level to use for storing the received 
objects
    +   */
    +  def createQueryStream(
    --- End diff --
    
    I believe that you will have problem with default params when you will try 
to add another overload to `createStream`. Scala allows only one version of 
`createStream` with default params. So you will have manually add versions of 
`createStream` just like you have done for `JavaStreamingContext`.
    
    Also please 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to