Github user markgrover commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18765#discussion_r130668429
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
           sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
         }
       }
    +
    +  private[util] val REDACTION_REPLACEMENT_TEXT = "*********(redacted)"
    +  private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
    --- End diff --
    
    I think what's really happening here is that we are backporting some 
changes introduced in SPARK-18535 while backporting this JIRA (SPARK-19720). 
SPARK-18535 is a dependency of this, so if we want to backport this, we should 
really be backporting SPARK-18535 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to