Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18630#discussion_r130754452
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1315,6 +1294,80 @@ private[spark] object SparkSubmitUtils {
}
+private [deploy] object DependencyUtils {
--- End diff --
Do you mind moving this to a separate source file?
I think there's other stuff in `SparkSubmit` that should eventually be
moved here, but it's ok to leave that for later.
Also, nit: no space after `private`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
