Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18253#discussion_r130759258
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -2379,8 +2382,13 @@ class SparkContext(config: SparkConf) extends
Logging {
" parameter from breaking Spark's ability to find a valid
constructor.")
}
}
- listenerBus.addListener(listener)
- logInfo(s"Registered listener $className")
+ logInfo(s"listener $className created")
+ listener
+ }
+ if (extraListeners.nonEmpty) {
+ val group = new FixGroupOfListener(extraListeners,
"extraListeners")
--- End diff --
> First, I think that modifying the existing addListener method is a bad
idea. It will impact a lot the code.
That's why overloaded methods exist.
> But I have 2 kind of group of listeners
I don't think there's really a distinction between the two types of groups
you mention. The "UI group" is just a modifiable group that you don't modify
after it's been created.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
