Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18734#discussion_r130774005
--- Diff: python/pyspark/cloudpickle.py ---
@@ -220,12 +322,7 @@ def save_function(self, obj, name=None):
if name is None:
name = obj.__name__
- try:
- # whichmodule() could fail, see
- #
https://bitbucket.org/gutworth/six/issues/63/importing-six-breaks-pickling
- modname = pickle.whichmodule(obj, name)
- except Exception:
- modname = None
+ modname = pickle.whichmodule(obj, name)
--- End diff --
It's a good question, the underlying issue was marked resolved in 2014 and
from looking at the commit it seems like it should actually be resolved. That
being said its true some people might be on a system installed with an old
verison of six so perhaps we should keep this workaround.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
