Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18804#discussion_r130783264
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -642,8 +642,15 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
           if (stats.get.rowCount.isDefined) {
             statsProperties += STATISTICS_NUM_ROWS -> 
stats.get.rowCount.get.toString()
           }
    +
    +      // For datasource tables the data schema is stored in the table 
properties.
    +      val schema = rawTable.properties.get(DATASOURCE_PROVIDER) match {
    +        case Some(provider) => getSchemaFromTableProperties(rawTable)
    +        case _ => rawTable.schema
    --- End diff --
    
    Maybe call `restoreTableMetadata` to avoid duplicate logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to