Github user yaooqinn commented on a diff in the pull request:
https://github.com/apache/spark/pull/18668#discussion_r130792745
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
---
@@ -283,4 +283,17 @@ class CliSuite extends SparkFunSuite with
BeforeAndAfterAll with Logging {
"SET conf3;" -> "conftest"
)
}
+
+ test("SPARK-21451: spark.sql.warehouse.dir should respect options in
--hiveconf") {
+ runCliWithin(1.minute)("set spark.sql.warehouse.dir;" ->
warehousePath.getAbsolutePath)
+ }
+
+ test("SPARK-21451: Apply spark.hadoop.* configurations") {
--- End diff --
Yes, after sc initialized, spark.hadoop.hive.metastore.warehouse.dir will
be translated into a hadoop conf hive.metastore.warehouse.dir as an alternative
of warehouse dir. This test case couldn't tell whether this pr works. CliSuite
may not see these values only if we explicitly set them to SqlConf.
The original code did break another test case anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
