Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18824#discussion_r131047358
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -616,15 +616,24 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
// Add table metadata such as table schema, partition columns, etc. to
table properties.
val updatedTable = withNewSchema.copy(
properties = withNewSchema.properties ++
tableMetaToTableProps(withNewSchema))
+
+ // If it's a data source table, make sure the original schema is left
unchanged; the
+ // actual schema is recorded as a table property.
+ val tableToStore = if (DDLUtils.isDatasourceTable(updatedTable)) {
+ updatedTable.copy(schema = rawTable.schema)
+ } else {
+ updatedTable
+ }
+
try {
- client.alterTable(updatedTable)
+ client.alterTable(tableToStore)
} catch {
case NonFatal(e) =>
val warningMessage =
s"Could not alter schema of table
${rawTable.identifier.quotedString} in a Hive " +
"compatible way. Updating Hive metastore in Spark SQL specific
format."
logWarning(warningMessage, e)
- client.alterTable(updatedTable.copy(schema =
updatedTable.partitionSchema))
+ client.alterTable(updatedTable.copy(schema =
tableToStore.partitionSchema))
--- End diff --
I think this part is directly related to the logic which converts the table
metadata to Spark SQL specific format:
https://github.com/apache/spark/blob/f18b905f6cace7686ef169fda7de474079d0af23/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L290-L301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
