Github user sethah commented on the issue: https://github.com/apache/spark/pull/18832 The comment is not wrong. It's added for when we are finding the best split, to compute the right child stats from the left child stats. We would have just used the stats that are already available on the node `node.stats`, but those aren't available on the first iteration. In the method `binsToBestSplit`: ````scala var gainAndImpurityStats: ImpurityStats = if (level == 0) { null } else { node.stats } ```` Otherwise, instead of parent stats we would just use `node.stats.impurityCalculator`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org