Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18820#discussion_r131208895
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1423,8 +1434,9 @@ def all_of_(xs):
                 subset = [subset]
     
             # Verify we were not passed in mixed type generics."
    -        if not any(all_of_type(rep_dict.keys()) and 
all_of_type(rep_dict.values())
    -                   for all_of_type in [all_of_bool, all_of_str, 
all_of_numeric]):
    +        if not any(key_all_of_type(rep_dict.keys()) and 
value_all_of_type(rep_dict.values())
    +                   for (key_all_of_type, value_all_of_type)
    +                   in [all_of_bool, all_of_str, all_of_numeric]):
    --- End diff --
    
    Why not just put `None` here and keep the various `all_of_*` variables 
defined as they were before?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to