Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131286586
--- Diff: python/pyspark/ml/util.py ---
@@ -61,20 +66,74 @@ def _randomUID(cls):
@inherit_doc
-class MLWriter(object):
+class BaseReadWrite(object):
+ """
+ Base class for MLWriter and MLReader. Stores information about the
SparkContext
+ and SparkSession.
+
+ .. versionadded:: 2.3.0
+ """
+
+ def __init__(self):
+ self._sparkSession = None
+
+ def context(self, sqlContext):
+ """
+ Sets the Spark SQLContext to use for saving/loading.
+
+ .. note:: Deprecated in 2.1 and will be removed in 3.0, use
session instead.
+ """
+ raise NotImplementedError("MLWriter is not yet implemented for
type: %s" % type(self))
+
+ def session(self, sparkSession):
+ """
+ Sets the Spark Session to use for saving/loading.
+ """
+ self._sparkSession = sparkSession
+ return self
+
+ def sparkSession(self):
--- End diff --
Copy doc from Scala. Also, this could be a ```@property``` to match Scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
