Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18779#discussion_r131328405
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -557,4 +557,22 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
}
assert(e.message.contains("aggregate functions are not allowed in
GROUP BY"))
}
+
+ test("SPARK-21580 ints in aggregation expressions are taken as group-by
ordinal.") {
--- End diff --
Please also add order-by test too. Maybe add to `DataFrameSuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
