Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131331807
--- Diff: python/pyspark/ml/util.py ---
@@ -156,28 +218,23 @@ def write(self):
@inherit_doc
-class MLReader(object):
+class MLReader(BaseReadWrite):
"""
Utility class that can load ML instances.
.. versionadded:: 2.0.0
"""
+ def __init__(self):
+ super(MLReader, self).__init__()
+
def load(self, path):
"""Load the ML instance from the input path."""
raise NotImplementedError("MLReader is not yet implemented for
type: %s" % type(self))
- def context(self, sqlContext):
- """
- Sets the SQL context to use for loading.
-
- .. note:: Deprecated in 2.1 and will be removed in 3.0, use
session instead.
- """
- raise NotImplementedError("MLReader is not yet implemented for
type: %s" % type(self))
-
def session(self, sparkSession):
--- End diff --
You can remove this instance of session since it is inherited.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
