Github user eatoncys commented on a diff in the pull request:
https://github.com/apache/spark/pull/18810#discussion_r131340166
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -356,6 +356,16 @@ class CodegenContext {
private val placeHolderToComments = new mutable.HashMap[String, String]
/**
+ * Returns the length of codegen function is too long or not
+ */
+ def existTooLongFunction(): Boolean = {
+ classFunctions.exists { case (className, functions) =>
+ functions.exists{ case (name, code) =>
+ CodeFormatter.stripExtraNewLines(code).count(_ == '\n') >
SQLConf.get.maxFunctionLength
--- End diff --
@kiszk Because when the JVM parameter -XX:+DontCompileHugeMethods is true,
it can not get the JIT optimization when the byte code of a function is longer
than 8000, here I just estimate a function lines by 8000 byte code, maybe there
are some other good ways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
