Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18841#discussion_r131512180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala
---
@@ -170,29 +193,29 @@ case class Pi() extends LeafMathExpression(math.Pi,
"PI")
// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(expr) - Returns the inverse cosine (a.k.a. arccosine) of
`expr` if -1<=`expr`<=1 or NaN otherwise.",
+ usage = "_FUNC_(expr) - Returns the inverse cosine (a.k.a. arccosine) of
`expr` if -1<=`expr`<=1 or NULL otherwise.",
extended = """
Examples:
> SELECT _FUNC_(1);
0.0
> SELECT _FUNC_(2);
- NaN
+ NULL
--- End diff --
I checked the Hive patch. I saw there is a comment that questions about NaN
in Hive. In SparkSQL, I think NaN is used in some expressions, e.g., IsNaN,
NaNvl. Maybe we should keep the existing behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
