Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18797#discussion_r131522271
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/mllib/optimization/LBFGSSuite.scala ---
    @@ -191,8 +191,8 @@ class LBFGSSuite extends SparkFunSuite with 
MLlibTestSparkContext with Matchers
         // With smaller convergenceTol, it takes more steps.
         assert(lossLBFGS3.length > lossLBFGS2.length)
     
    -    // Based on observation, lossLBFGS3 runs 7 iterations, no 
theoretically guaranteed.
    -    assert(lossLBFGS3.length == 7)
    +    // Based on observation, lossLBFGS3 runs 6 iterations, no 
theoretically guaranteed.
    +    assert(lossLBFGS3.length == 6)
    --- End diff --
    
    If no theoretically guaranteed, why we need to keep this test? I remember 
we change here multiple times when we did breeze upgrade. What do you think 
about just removing this line? We never check the number of iterations at other 
test suites. @srowen @WeichenXu123 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to