Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18854#discussion_r131531879
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
 ---
    @@ -396,6 +396,8 @@ case class Or(left: Expression, right: Expression) 
extends BinaryOperator with P
     
       override def sqlOperator: String = "OR"
     
    +  override def nullable: Boolean = left.nullable && right.nullable
    --- End diff --
    
    Actually the current `def nullable: Boolean = left.nullable || 
right.nullable` for `Or` is not very accurate too.
    
    At least when any of left/right is true, its `nullable` should be false.
    
    Although we can't know if any of left/right is true under most of cases, 
but if they are foldable, then we can know that.
    
    @gatorsmile @hvanhovell What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to