Github user viirya commented on a diff in the pull request:
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
    @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with 
SharedSQLContext {
         val e2 = 
         assert(e2.message.contains("Cannot modify the value of a static 
    +  test("SPARK-21588 SQLContext.getConf(key, null) should return null") {
    +    withSQLConf(SQLConf.SHUFFLE_PARTITIONS.key -> "1") {
    +      assert("1" == spark.conf.get(SQLConf.SHUFFLE_PARTITIONS.key, null))
    +      assert("1" == spark.conf.get(SQLConf.SHUFFLE_PARTITIONS.key, 
    +    }
    +    assert(spark.conf.getOption("spark.sql.nonexistent").isEmpty)
    +    assert(null == spark.conf.get("spark.sql.nonexistent", null))
    --- End diff --
    Yeah, those tests are good. We should add another test for NPE case too.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to